Skip to content

feat(routing/http)!: delegated peer routing server and client, IPIP 417#422

Merged
hacdias merged 17 commits intomainfrom
ipip-417
Aug 25, 2023
Merged

feat(routing/http)!: delegated peer routing server and client, IPIP 417#422
hacdias merged 17 commits intomainfrom
ipip-417

Conversation

@hacdias
Copy link
Member

@hacdias hacdias commented Aug 2, 2023 •
edited
Loading

Implementation of ipfs/specs#417. Requires #333.

  • Removes generic Provide.
  • Marks ProvideBitswap and all related methods and types as deprecated.
  • Add Peer Routing functions to the client. Tests.
  • Add Peer Routing functions to the server. Tests.
  • Chagelog for more updates.

Kubo PR (includes #333): ipfs/kubo#9877

@hacdias hacdias self-assigned this Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited
Loading

Codecov Report

Merging #422 (6c62606) into main (79159c3) will increase coverage by 0.04%.
The diff coverage is 65.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   66.34%   66.38%   +0.04%     
==========================================
  Files         205      207       +2     
  Lines       24399    24681     +282     
==========================================
+ Hits        16187    16385     +198     
- Misses       6803     6867      +64     
- Partials     1409     1429      +20
Files Changed Coverage Δ
routing/http/types/json/responses.go 45.45% <45.45%> (ø)
routing/http/types/record_unknown.go 45.45% <45.45%> (ø)
routing/http/types/json/requests.go 46.66% <46.66%> (ø)
routing/http/contentrouter/contentrouter.go 48.08% <48.07%> (-3.11%) ⬇️
routing/http/types/ndjson/records.go 53.33% <53.33%> (ø)
routing/http/types/record_bitswap.go 40.69% <63.63%> (ø)
routing/http/server/server.go 67.45% <74.86%> (+6.54%) ⬆️
routing/http/types/iter/iter.go 89.28% <78.57%> (-10.72%) ⬇️
routing/http/types/record_peer.go 80.85% <80.85%> (ø)
routing/http/client/client.go 74.59% <84.81%> (+1.61%) ⬆️

... and 13 files with indirect coverage changes

@hacdias hacdias force-pushed the ipip-417 branch 2 times, most recently from 9ce5527 to ba63f59 Compare August 2, 2023 13:28
@hacdias hacdias mentioned this pull request Aug 7, 2023
Merged
13 tasks
@hacdias hacdias force-pushed the ipip-417 branch 8 times, most recently from 16fbd19 to c4ed06e Compare August 8, 2023 13:14
@hacdias hacdias requested a review from lidel August 8, 2023 14:37
@hacdias hacdias marked this pull request as ready for review August 8, 2023 14:37
@hacdias hacdias requested a review from a team as a code owner August 8, 2023 14:37
@hacdias hacdias force-pushed the ipip-417 branch 2 times, most recently from 7f1c23c to ecc6fb4 Compare August 9, 2023 09:33
@hacdias hacdias mentioned this pull request Aug 9, 2023
Closed
@BigLep
Copy link
Contributor

BigLep commented Aug 9, 2023

Just wanted to say thanks for jumping on this @hacdias as this is key for ipfs/helia#182

@BigLep BigLep mentioned this pull request Aug 9, 2023
Open
@lidel lidel mentioned this pull request Aug 22, 2023
Merged
3 tasks
lidel
lidel requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight concern around inconsitent naming across our stack + breaking PUTs for existign users like ipni/index-provider (details inline).

Base automatically changed from ipip-379 to main August 22, 2023 05:37
lidel
lidel reviewed Aug 25, 2023
View reviewed changes
lidel
lidel reviewed Aug 25, 2023
View reviewed changes
@hacdias hacdias force-pushed the ipip-417 branch 3 times, most recently from a24e870 to a55f17a Compare August 25, 2023 12:30
lidel
lidel reviewed Aug 25, 2023
View reviewed changes
lidel
lidel reviewed Aug 25, 2023
View reviewed changes
lidel
lidel reviewed Aug 25, 2023
View reviewed changes
lidel
lidel reviewed Aug 25, 2023
View reviewed changes
@hacdias hacdias merged commit 1356946 into main Aug 25, 2023
@hacdias hacdias deleted the ipip-417 branch August 25, 2023 15:19
@lidel lidel mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidel lidel lidel approved these changes

Assignees

@hacdias hacdias

Labels

None yet

Projects

No open projects
IPFS Shipyard Team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hacdias @BigLep @lidel